refactor(harness): extract retained workspace scope owners (SAP-3091) - #909

Primary change type

• Bug fix
• Documentation
• Feature
• Tests
• Dependency update
• Maintenance or refactor

Problem and motivation

Workspace identity, allowed-root resolution and per-agent invocation types were still owned by mixed legacy graph modules. Deleting those modules directly would remove contracts used by current Studio discovery and Canvas.

Summary and scope

Extract workspace scope types and local identity helpers into shared/workspace-scope.ts, the catalog into core/workspace-scope-catalog.ts, and containment helpers into core/workspace-path.ts. Move AgentInvocationMode to Canvas ownership. Repoint live imports, browser aliases and the existing public type export; temporary legacy re-exports keep this boundary buildable.

Related work

Related issue or discussion: SAP-3091. Part of the authorized cleanup stack above #892 and #893, targeting main. The seven layers are intended to merge and ship together. Updated layers require maintainer approval before merge.

Validation

Review-fix verification on cumulative source 5bfed981, including current main (8679d745). Server and browser typechecks also passed on each of the seven isolated PR heads.

pnpm --filter '@sapiom/harness...' build — passed
pnpm --filter @sapiom/harness typecheck — passed
pnpm --filter @sapiom/harness lint — passed
pnpm --filter @sapiom/harness exec vitest run --maxWorkers=2 — 3,845 passed, 2 skipped
pnpm --filter @sapiom/harness test:perf — 10 passed
pnpm --filter @sapiom/harness exec playwright test --config <local Chrome override> --workers=2 — 634 passed
pnpm --filter @sapiom/harness exec playwright test --config <Canvas Chrome override> --workers=2 — 15 passed
pnpm terminology:check — passed
pnpm provider-copy:check — passed

The browser override selects the installed Google Chrome, temporary output paths and pnpm exec vite; it preserves the checked-in tests and assertions. All 16 focused map/style/project-tab cases passed, including light/dark computed styles, project/agent viewport restoration, offscreen recovery, automatic fitting, auth isolation and layout recovery. The viewport and metadata regressions failed before their fixes. The new viewport and project-altitude tests also passed on #907's own intermediate tree (10 cases).

An initial three-worker Harness run failed one archive-wiring case; the affected file passed unchanged 8/8, followed by the complete passing two-worker run above. The main integration passed 263 focused cases, and #892's resolved auth mock passed 4/4 on its own tree. No tests or admission guards were weakened.

All PR heads include main's deliberate removal of the duplicate Claude workflow in #886. The reviewed commits remain in history; the stack update uses ordinary fast-forward pushes. Fresh build hashes and the earlier package/smoke evidence are recorded in the retirement record. Signed macOS installer/upgrade validation remains SAP-3086.

CI follow-up: the first Node 20 run hit the same archive-wiring failure noted above and cancelled Node 22 through matrix fail-fast. The unchanged rerun passed on both Node 20 and Node 22. The archive test, reader, writer and event store match main byte-for-byte.

Tests and documentation

Retained workspace identity, catalog, source containment, public export and per-agent Canvas tests remain at their neutral owners. The moved logic is unchanged.

Compatibility and release impact

• Breaking or externally visible changes: Retained public WorkspaceScopeSummary and PackageInventory shapes are unchanged. This is an internal ownership move with no runtime migration.
• Changeset: N/A — internal module/type moves preserve the existing public API and ship with the surrounding cleanup changesets.

Security

• I have not included secrets, credentials, private data, or unsanitized logs.
• This pull request does not publicly disclose a suspected vulnerability. I will follow the Security Policy for private reporting.

AI assistance

• I did not use AI assistance for this change.
• I used AI assistance and have described it below.

Codex implemented the cleanup and test/doc migrations, traced retained callers, and checked the resulting diffs. Automated checks above and independent read-only review provide implementation evidence; maintainer review is still required.

Checklist

• I read CONTRIBUTING.md, and this contribution follows the direct-PR or issue-first policy.
• This pull request addresses one focused problem and contains no unrelated cleanup.
• I added or updated tests, or explained above why tests are not applicable.
• I ran the relevant build, typecheck, lint, and test commands, or explained any N/A checks above.
• I updated documentation for user-facing changes, or marked it N/A above.
• I added a Changeset for a published-package change, or explained why it is not applicable.
• I can explain and maintain every submitted change, including any AI-assisted work.